whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cmake: disable snippets/graphicsview if "printdialog" is not available 

The graphicsview doc snippet has an explicit
QT_REQUIRE_CONFIG(printdialog) check that will fail the
build if Qt is not configured with "printdialog".
This check should be mirrored in the cmake file, so that
we skip building the snippet in the first place if the
feature is not available.

As it stood, we would build the snippet if "printsupport"
was enabled. But this is too granular, as you can configure
Qt to have general print support, but at the same time, skip
the print dialog. This caused the build to fail on iOS.

This patch will check the correct feature in the cmake file.

Change-Id: I31acc1f7c257e08374ea7b84a7fc38c66f214271
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
bb10
Richard Moe Gustavsen 2021-02-23 16:44:13 +01:00
parent ba13960392
commit 9d80deb92f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/widgets/CMakeLists.txt
View File

@ -829,7 +829,7 @@ if(QT_FEATURE_private_tests)
add_subdirectory(doc/snippets/customviewstyle)
add_subdirectory(doc/snippets/filedialogurls)
add_subdirectory(doc/snippets/graphicssceneadditem)
if(QT_FEATURE_opengl AND QT_FEATURE_printsupport)
if(QT_FEATURE_opengl AND QT_FEATURE_printdialog)
add_subdirectory(doc/snippets/graphicsview)
endif()
add_subdirectory(doc/snippets/mdiarea)