From 9ee30b1dc2f7a6a4d470a35fb250769f12e03ad9 Mon Sep 17 00:00:00 2001 From: Laszlo Agocs Date: Thu, 9 Nov 2023 12:55:06 +0100 Subject: [PATCH] Fix broken capture in hellovulkancubes example MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Amends 339323b999feed077adecc0afaa215f8caffc043 Capturing a function argument (or any local variable) by address is a bad idea. Fixes: QTBUG-118912 Fixes: QTBUG-118986 Change-Id: I521d319a37f7acd6c66732f5f7d3cf1be4d49029 Reviewed-by: MÃ¥rten Nordheim Reviewed-by: Ahmad Samir --- examples/vulkan/hellovulkancubes/mainwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vulkan/hellovulkancubes/mainwindow.cpp b/examples/vulkan/hellovulkancubes/mainwindow.cpp index 5a41b54152..198a168bce 100644 --- a/examples/vulkan/hellovulkancubes/mainwindow.cpp +++ b/examples/vulkan/hellovulkancubes/mainwindow.cpp @@ -42,7 +42,7 @@ MainWindow::MainWindow(VulkanWindow *vulkanWindow) pauseButton->setFocusPolicy(Qt::NoFocus); connect(quitButton, &QPushButton::clicked, qApp, &QCoreApplication::quit); - connect(newButton, &QPushButton::clicked, vulkanWindow, [this, &vulkanWindow] { + connect(newButton, &QPushButton::clicked, vulkanWindow, [this, vulkanWindow] { vulkanWindow->addNew(); m_count = vulkanWindow->instanceCount(); counterLcd->display(m_count);