whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tst_QtConcurrentThreadEngine: fix UB (uninitialized boolean) 

Says ubsan:

    tst_qtconcurrentthreadengine.cpp:96:17: runtime error: load of value 190, which is not a valid value for type 'bool'
    PASS   : tst_QtConcurrentThreadEngine::stresstest()

Initialize the variable using NSDMI.

Amends the start of the public history.

Reported-by: Even Oscar Andersen <even.oscar.andersen@qt.io>
Pick-to: 6.7 6.5 6.2 5.15
Task-number: QTBUG-115264
Change-Id: Ie55bc0a697a71074066294d64821c8a7a0d1f467
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Even Oscar Andersen <even.oscar.andersen@qt.io>
(cherry picked from commit 32442c2b52381f5e4164ae217453a8e8391d9349)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
bb10
Marc Mutz 2024-07-02 11:04:26 +02:00 committed by Qt Cherry-pick Bot
parent 056c89e95d
commit 9ef785082a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/auto/concurrent/qtconcurrentthreadengine/tst_qtconcurrentthreadengine.cpp
View File

@ -106,7 +106,7 @@ public:
{
return 0;
}
bool done;
bool done = false;
};
void tst_QtConcurrentThreadEngine::runThroughStarter()