From a097825b2135ebfde45a122ea9252954f4ddcd5f Mon Sep 17 00:00:00 2001 From: Jason McDonald Date: Wed, 21 Sep 2011 10:38:09 +1000 Subject: [PATCH] Don't run multiexec test with file logging The multiexec test runs the same test object five times. If the -o option is given, the output file is overwritten by each run of the test object, meaning that tst_selftest only sees 1/5 of the test output in a file compared with what it sees on the console. This makes it impossible to use the expected output file to verify the test for both console and file output. This issue is noted in QTBUG-21561. Change-Id: I00031a2ea43a7ef78e8317473a089306ec062d8e Reviewed-on: http://codereview.qt-project.org/5270 Reviewed-by: Qt Sanity Bot Reviewed-by: Rohan McGovern --- tests/auto/testlib/selftests/tst_selftests.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/auto/testlib/selftests/tst_selftests.cpp b/tests/auto/testlib/selftests/tst_selftests.cpp index bd0594dbcf..5efaedbd86 100644 --- a/tests/auto/testlib/selftests/tst_selftests.cpp +++ b/tests/auto/testlib/selftests/tst_selftests.cpp @@ -270,12 +270,17 @@ void tst_Selftests::runSubTest_data() arguments << "-eventcounter"; } - // These tests don't work right with loggers other than plain text, usually because - // they internally supply arguments to themselves. + // These tests don't work right unless logging plain text to + // standard output, either because they execute multiple test + // objects or because they internally supply arguments to + // themselves. if (logger.name != "txt") { if (subtest == "differentexec") { continue; } + if (subtest == "multiexec") { + continue; + } if (subtest == "qexecstringlist") { continue; }