From a10c8647b3d9f7e12ca1a3bf5a9229b50a63a318 Mon Sep 17 00:00:00 2001
From: Anton Kudryavtsev <anton.kudryavtsev@vk.team>
Date: Tue, 22 Aug 2023 16:10:23 +0300
Subject: [PATCH] qhttpnetworkreques: use range based for more
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

to improve readability

Change-Id: I4d4342f45296e2d6f439c6a74292c6c922e95194
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
---
 src/network/access/qhttpnetworkrequest.cpp | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/network/access/qhttpnetworkrequest.cpp b/src/network/access/qhttpnetworkrequest.cpp
index d5e529f6b9..c207cfae38 100644
--- a/src/network/access/qhttpnetworkrequest.cpp
+++ b/src/network/access/qhttpnetworkrequest.cpp
@@ -112,7 +112,7 @@ QByteArray QHttpNetworkRequest::uri(bool throughProxy) const
 
 QByteArray QHttpNetworkRequestPrivate::header(const QHttpNetworkRequest &request, bool throughProxy)
 {
-    QList<QPair<QByteArray, QByteArray> > fields = request.header();
+    const QList<QPair<QByteArray, QByteArray> > fields = request.header();
     QByteArray ba;
     ba.reserve(40 + fields.size()*25); // very rough lower bound estimation
 
@@ -126,12 +126,10 @@ QByteArray QHttpNetworkRequestPrivate::header(const QHttpNetworkRequest &request
     ba += QByteArray::number(request.minorVersion());
     ba += "\r\n";
 
-    QList<QPair<QByteArray, QByteArray> >::const_iterator it = fields.constBegin();
-    QList<QPair<QByteArray, QByteArray> >::const_iterator endIt = fields.constEnd();
-    for (; it != endIt; ++it) {
-        ba += it->first;
+    for (const auto& [name, value] : fields) {
+        ba += name;
         ba += ": ";
-        ba += it->second;
+        ba += value;
         ba += "\r\n";
     }
     if (request.d->operation == QHttpNetworkRequest::Post) {