From bad3b8f78b9eddb9dd5c08d96f9ee8137d98c19e Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Fri, 14 Jul 2023 21:14:39 +0200 Subject: [PATCH] tst_QNetworkDiskCache: fix mem-leak MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A caller of Q(Abstract)NetworkDiskCache::data() is supposed to delete the returned value, and this caller forgot. Do it now; better late than never. Amends feb1afc78290433b0c22b1b3f6d65542eeb5b957. Pick-to: 6.6 6.5 6.2 5.15 Change-Id: I1b27663df9ad49e0203172265d224fdb6ec06646 Reviewed-by: MÃ¥rten Nordheim --- .../network/access/qnetworkdiskcache/tst_qnetworkdiskcache.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/auto/network/access/qnetworkdiskcache/tst_qnetworkdiskcache.cpp b/tests/auto/network/access/qnetworkdiskcache/tst_qnetworkdiskcache.cpp index d8c6633c2a..39199c91b5 100644 --- a/tests/auto/network/access/qnetworkdiskcache/tst_qnetworkdiskcache.cpp +++ b/tests/auto/network/access/qnetworkdiskcache/tst_qnetworkdiskcache.cpp @@ -657,6 +657,7 @@ void tst_QNetworkDiskCache::streamVersion() QIODevice *dataDevice = cache.data(url); QVERIFY(dataDevice != 0); QByteArray cachedData = dataDevice->readAll(); + delete dataDevice; QCOMPARE(cachedData, data); } }