whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix item view auto-scrolling during drag'n'drop 

Amends 71aaf831d1, which wrongly assumed
that dragMoveEvent will be called and update the dragged position as we
scroll the viewport. This is not the case, so we have to do so manually
when the view is in DraggingState.

Since dragMoveEvent cannot be faked, and since we cannot fake a
mouseMoveEvent (it would throw off the drag'n'drop state machine),
calculate the new draggedPosition based on old position and the new
offset.

As with all drag'n'drop, we cannot test this using an auto test.

Task-number: QTBUG-96124
Fixes: QTBUG-98961
Change-Id: Ifcfc1a11aa7258ec4610a548a276b4dd4a814590
Reviewed-by: Zhang Hao <zhanghao@uniontech.com>
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
bb10
Volker Hilsheimer 2021-12-07 14:24:58 +01:00
parent 9da1f6b608
commit bae0a159d8
1 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/widgets/itemviews/qabstractitemview.cpp
View File

@ -3982,14 +3982,14 @@ void QAbstractItemView::doAutoScroll()
}
}
int verticalStep = verticalScroll->pageStep();
int horizontalStep = horizontalScroll->pageStep();
const int verticalStep = verticalScroll->pageStep();
const int horizontalStep = horizontalScroll->pageStep();
if (d->autoScrollCount < qMax(verticalStep, horizontalStep))
++d->autoScrollCount;
int margin = d->autoScrollMargin;
int verticalValue = verticalScroll->value();
int horizontalValue = horizontalScroll->value();
const int margin = d->autoScrollMargin;
const int verticalValue = verticalScroll->value();
const int horizontalValue = horizontalScroll->value();
const QPoint pos = d->draggedPosition - d->offset();
const QRect area = QWidgetPrivate::get(d->viewport)->clipRect();
@ -4004,8 +4004,8 @@ void QAbstractItemView::doAutoScroll()
else if (area.right() - pos.x() < margin)
horizontalScroll->setValue(horizontalValue + d->autoScrollCount);
// if nothing changed, stop scrolling
bool verticalUnchanged = (verticalValue == verticalScroll->value());
bool horizontalUnchanged = (horizontalValue == horizontalScroll->value());
const bool verticalUnchanged = (verticalValue == verticalScroll->value());
const bool horizontalUnchanged = (horizontalValue == horizontalScroll->value());
if (verticalUnchanged && horizontalUnchanged) {
stopAutoScroll();
} else {
@ -4013,13 +4013,29 @@ void QAbstractItemView::doAutoScroll()
d->dropIndicatorRect = QRect();
d->dropIndicatorPosition = QAbstractItemView::OnViewport;
#endif
if (state() == QAbstractItemView::DragSelectingState) {
switch (state()) {
case QAbstractItemView::DragSelectingState: {
// mouseMoveEvent updates the drag-selection rectangle, so fake an event. This also
// updates draggedPosition taking the now scrolled viewport into account.
const QPoint globalPos = d->viewport->mapToGlobal(pos);
const QPoint windowPos = window()->mapFromGlobal(globalPos);
QMouseEvent mm(QEvent::MouseMove, pos, windowPos, globalPos,
Qt::NoButton, Qt::LeftButton, d->pressedModifiers,
Qt::MouseEventSynthesizedByQt);
QApplication::sendEvent(viewport(), &mm);
break;
}
case QAbstractItemView::DraggingState: {
// we can't simulate mouse (it would throw off the drag'n'drop state logic) or drag
// (we don't have the mime data or the actions) move events during drag'n'drop, so
// update our dragged position manually after the scroll. "pos" is the old
// draggedPosition - d->offset(), and d->offset() is now updated after scrolling, so
// pos + d->offset() gives us the new position.
d->draggedPosition = pos + d->offset();
break;
}
default:
break;
}
d->viewport->update();
}