whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix infinite loop in QTextLayout with setNumColumns() 

If the line width is negative, then we might exit the layout
loop before consuming any text, and thus the loop will never
finish. This is a side effect of a change for maximumWidth:
991c056438.

49a63d3759 fixed this issue for
QTextLayout::setFixedSize(), but I forgot to do the same in
the overload of QTextLayout::setNumColumns() which includes
an alignment width and therefore sets the line width in addition
to the column count.

Basically, we just make sure the line width is never negative so
that the width > line.width condition also means the width > 0.

Pick-to: 6.5 6.6 6.7
Fixes: QTBUG-115459
Change-Id: If904bfc64cd74e819a0864db55fa9555073d0781
Reviewed-by: Vladimir Belyavsky <belyavskyv@gmail.com>
Reviewed-by: Lars Knoll <lars@knoll.priv.no>
bb10
Eskil Abrahamsen Blomfeldt 2024-01-29 11:44:25 +01:00
parent f757662486
commit be6c651be4
2 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gui/text/qtextlayout.cpp
View File

@ -1652,7 +1652,7 @@ void QTextLine::setNumColumns(int numColumns)
void QTextLine::setNumColumns(int numColumns, qreal alignmentWidth)
{
QScriptLine &line = eng->lines[index];
line.width = QFixed::fromReal(alignmentWidth);
line.width = QFixed::fromReal(qBound(0.0, alignmentWidth, qreal(QFIXED_MAX)));
line.length = 0;
line.textWidth = 0;
layout_helper(numColumns);

26
tests/auto/gui/text/qtextlayout/tst_qtextlayout.cpp
View File

@ -2737,13 +2737,25 @@ void tst_QTextLayout::min_maximumWidth()
void tst_QTextLayout::negativeLineWidth()
{
QTextLayout layout;
layout.setText("Foo bar");
layout.beginLayout();
QTextLine line = layout.createLine();
line.setLineWidth(-1);
QVERIFY(line.textLength() > 0);
layout.endLayout();
{
QTextLayout layout;
layout.setText("Foo bar");
layout.beginLayout();
QTextLine line = layout.createLine();
line.setLineWidth(-1);
QVERIFY(line.textLength() > 0);
layout.endLayout();
}
{
QTextLayout layout;
layout.setText("Foo bar");
layout.beginLayout();
QTextLine line = layout.createLine();
line.setNumColumns(2, -1);
QVERIFY(line.textLength() > 0);
layout.endLayout();
}
}
QTEST_MAIN(tst_QTextLayout)