whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix warnings in tst_q{table,list}widget 

GCC warned:

  tst_qtablewidget.cpp:30:
  tst_qtablewidget.cpp: In member function ‘void tst_QTableWidget::mimeData()’:
  qtestcase.h:66:52: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
       if (!QTest::qVerify(static_cast<bool>(statement), #statement, "", __FILE__, __LINE__))\
                                                      ^
  tst_qtablewidget.cpp:1523:5: note: in expansion of macro ‘QVERIFY’
       QVERIFY(data = table.mimeData(tableWidgetItemList));
       ^~~~~~~

Fix by adding the extra parentheses, as usual.

Change-Id: I2826d7a865b4113b468d5a958ede06e03aa0e278
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
bb10
Marc Mutz 2016-09-30 15:51:30 +02:00
parent 8d8991c697
commit bebbaa43fd
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/auto/widgets/itemviews/qlistwidget/tst_qlistwidget.cpp
View File

@ -1688,16 +1688,16 @@ void tst_QListWidget::mimeData()
QMimeData *data;
QVERIFY(data = list.mimeData(tableWidgetItemList));
QVERIFY((data = list.mimeData(tableWidgetItemList)));
delete data;
QVERIFY(data = list.model()->mimeData(modelIndexList));
QVERIFY((data = list.model()->mimeData(modelIndexList)));
delete data;
QVERIFY(data = list.model()->mimeData(modelIndexList));
QVERIFY((data = list.model()->mimeData(modelIndexList)));
delete data;
QVERIFY(data = list.mimeData(tableWidgetItemList));
QVERIFY((data = list.mimeData(tableWidgetItemList)));
delete data;
// check the saved data is actually the same

8
tests/auto/widgets/itemviews/qtablewidget/tst_qtablewidget.cpp
View File

@ -1537,16 +1537,16 @@ void tst_QTableWidget::mimeData()
QMimeData *data;
QVERIFY(data = table.mimeData(tableWidgetItemList));
QVERIFY((data = table.mimeData(tableWidgetItemList)));
delete data;
QVERIFY(data = table.model()->mimeData(modelIndexList));
QVERIFY((data = table.model()->mimeData(modelIndexList)));
delete data;
QVERIFY(data = table.model()->mimeData(modelIndexList));
QVERIFY((data = table.model()->mimeData(modelIndexList)));
delete data;
QVERIFY(data = table.mimeData(tableWidgetItemList));
QVERIFY((data = table.mimeData(tableWidgetItemList)));
delete data;
// check the saved data is actually the same