From bf7ce1ff84a735056b64958349a8a831eafe4684 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Mon, 30 Nov 2015 14:19:39 +0100 Subject: [PATCH] QDirModel: replace a copy by a reference Since we are storing pointers to the elements of the vector thus copied, we better make sure we don't cause it to deep-copy. The old code was fragile in that sense, using a reference removes one layer of potential mess-ups. Change-Id: Ib8ebbb47c2a478b5e666e767d05429700b528afd Reviewed-by: Friedemann Kleint --- src/widgets/itemviews/qdirmodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/widgets/itemviews/qdirmodel.cpp b/src/widgets/itemviews/qdirmodel.cpp index ddc75ef176..daf00e9362 100644 --- a/src/widgets/itemviews/qdirmodel.cpp +++ b/src/widgets/itemviews/qdirmodel.cpp @@ -168,7 +168,7 @@ void QDirModelPrivate::invalidate() while (!nodes.empty()) { const QDirNode *current = nodes.pop(); current->stat = false; - const QVector children = current->children; + const QVector &children = current->children; for (int i = 0; i < children.count(); ++i) nodes.push(&children.at(i)); }