From c253e6542989ab1ecdd123960c3a69b1b0fe9351 Mon Sep 17 00:00:00 2001 From: Sona Kurazyan Date: Mon, 11 Apr 2022 11:57:34 +0200 Subject: [PATCH] QFileSelectorPrivate: don't pass QChar by const reference Change-Id: I8aeb31bf7ad7160636379f3248e327e158016526 Reviewed-by: Giuseppe D'Angelo --- src/corelib/io/qfileselector.cpp | 3 ++- src/corelib/io/qfileselector_p.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/corelib/io/qfileselector.cpp b/src/corelib/io/qfileselector.cpp index 2dd5d13e53..38f479dd0d 100644 --- a/src/corelib/io/qfileselector.cpp +++ b/src/corelib/io/qfileselector.cpp @@ -246,7 +246,8 @@ QUrl QFileSelector::select(const QUrl &filePath) const return ret; } -QString QFileSelectorPrivate::selectionHelper(const QString &path, const QString &fileName, const QStringList &selectors, const QChar &indicator) +QString QFileSelectorPrivate::selectionHelper(const QString &path, const QString &fileName, + const QStringList &selectors, QChar indicator) { /* selectionHelper does a depth-first search of possible selected files. Because there is strict selector ordering in the API, we can stop checking as soon as we find the file in a directory diff --git a/src/corelib/io/qfileselector_p.h b/src/corelib/io/qfileselector_p.h index 49022908b0..390bc76b3f 100644 --- a/src/corelib/io/qfileselector_p.h +++ b/src/corelib/io/qfileselector_p.h @@ -71,7 +71,7 @@ public: static QStringList platformSelectors(); static void addStatics(const QStringList &); //For loading GUI statics from other Qt modules static QString selectionHelper(const QString &path, const QString &fileName, - const QStringList &selectors, const QChar &indicator = u'+'); + const QStringList &selectors, QChar indicator = u'+'); QFileSelectorPrivate(); QString select(const QString &filePath) const;