From c5e2d5f73b26b556ab76ab980e28f6435935f092 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9rgio=20Martins?= Date: Thu, 12 Feb 2015 17:16:17 +0000 Subject: [PATCH] Improve readability of QFlags test It's moot to compare something with boolean semantics against 0. Furthermore, it might even fail to compile, as seen in change request 105258 Change-Id: I8e491a67080b2d5a666858e8655e9f549fa6be4d Reviewed-by: Marc Mutz --- src/gui/painting/qpaintengine.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gui/painting/qpaintengine.h b/src/gui/painting/qpaintengine.h index 10f1402ea6..eeca87ce16 100644 --- a/src/gui/painting/qpaintengine.h +++ b/src/gui/painting/qpaintengine.h @@ -212,7 +212,7 @@ public: inline void setDirty(DirtyFlags df); inline void clearDirty(DirtyFlags df); - bool hasFeature(PaintEngineFeatures feature) const { return (gccaps & feature) != 0; } + bool hasFeature(PaintEngineFeatures feature) const { return gccaps & feature; } QPainter *painter() const; @@ -312,7 +312,7 @@ inline void QPaintEngine::fix_neg_rect(int *x, int *y, int *w, int *h) inline bool QPaintEngine::testDirty(DirtyFlags df) { Q_ASSERT(state); - return ((state->dirtyFlags & df) != 0); + return state->dirtyFlags & df; } inline void QPaintEngine::setDirty(DirtyFlags df) {