From c87cbc38f1068d1b804875db30cee2ee21df7e4f Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Sat, 24 Jun 2023 12:36:50 +0200 Subject: [PATCH] QtTest: code tidies: use the 4-arg connect overload MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 3-arg connect is error-prone and makes the lifetime of the connection unclear. Change-Id: I51f9bd87caa9baa57d06c8f3fd9ed8b37ef49cae Reviewed-by: MÃ¥rten Nordheim --- src/testlib/qtestaccessible.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/testlib/qtestaccessible.h b/src/testlib/qtestaccessible.h index a9b237bd5d..90d0a94476 100644 --- a/src/testlib/qtestaccessible.h +++ b/src/testlib/qtestaccessible.h @@ -150,8 +150,8 @@ private: static void updateHandler(QAccessibleEvent *event) { auto ev = copyEvent(event); - if (ev->object()) { - QObject::connect(ev->object(), &QObject::destroyed, [&, ev](){ + if (auto obj = ev->object()) { + QObject::connect(obj, &QObject::destroyed, obj, [&, ev](){ auto index= eventList().indexOf(ev); if (index == -1) return;