whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve QWidget autotest 

There are two cases where a QCOMPARE may fail on some platforms. Rather
than disabling the QCOMPAREs with "#if 0", use QEXPECT_FAIL so that we
can look in the CI logs to see which platforms fail.

Change-Id: Ife93c8032e01a04e8068bf213e2040778c12f711
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
bb10
Jason McDonald 2011-10-31 17:44:11 +10:00 committed by Qt by Nokia
parent 3e05a987b1
commit ceb4dd4b54
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp
View File

@ -1932,10 +1932,10 @@ void tst_QWidget::showMaximized()
QVERIFY(!(layouted.windowState() & Qt::WindowMaximized));
// ### fixme: embedded may choose a different size to fit on the screen.
// Check platforms (QTBUG-22326)
#if 0
if (layouted.size() != layouted.sizeHint())
QEXPECT_FAIL("", "QTBUG-22326", Continue);
QCOMPARE(layouted.size(), layouted.sizeHint());
#endif
layouted.showMaximized();
QVERIFY(layouted.isMaximized());
QVERIFY(layouted.isVisible());
@ -2009,10 +2009,10 @@ void tst_QWidget::showFullScreen()
layouted.showNormal();
QVERIFY(!(layouted.windowState() & Qt::WindowFullScreen));
// ### fixme: embedded may choose a different size to fit on the screen. (QTBUG-22326)
#if 0
// ### fixme: embedded may choose a different size to fit on the screen.
if (layouted.size() != layouted.sizeHint())
QEXPECT_FAIL("", "QTBUG-22326", Continue);
QCOMPARE(layouted.size(), layouted.sizeHint());
#endif
layouted.showFullScreen();
QVERIFY(layouted.isFullScreen());