whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QCUPSSupport: fix misuse of QDateTime::addDays() 

QDateTime::addDays() is a const function and returns a new QDateTime with
the given days added, thus the current statement had no effect.

Found by applying Q_REQUIRED_RESULT in dev branch.

Change-Id: I1b061619d45d7806feaa2bf9fb6d9f0b43d63def
Reviewed-by: Richard J. Moore <rich@kde.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
bb10
David Faure 2014-04-07 14:03:16 +02:00 committed by The Qt Project
parent 6ea574d446
commit d2f5fdb20d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/printsupport/kernel/qcups.cpp
View File

@ -113,7 +113,7 @@ void QCUPSSupport::setJobHold(QPrinter *printer, const JobHoldUntil jobHold, con
QDateTime localDateTime = QDateTime::currentDateTime();
// Check if time is for tomorrow in case of DST change overnight
if (holdUntilTime < localDateTime.time())
localDateTime.addDays(1);
localDateTime = localDateTime.addDays(1);
localDateTime.setTime(holdUntilTime);
setCupsOption(cupsOptions,
QStringLiteral("job-hold-until"),