From d6bd73a3437d3e094c61861577a1921e9587b5db Mon Sep 17 00:00:00 2001 From: Anton Kudryavtsev Date: Thu, 7 Sep 2023 17:44:17 +0300 Subject: [PATCH] widgets: use const methods more to avoid implicit detach Change-Id: I44b2924decd3c650ece377784f4a73b4e5bbd6c6 Reviewed-by: Volker Hilsheimer --- src/widgets/widgets/qfontcombobox.cpp | 4 ++-- src/widgets/widgets/qkeysequenceedit.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/widgets/widgets/qfontcombobox.cpp b/src/widgets/widgets/qfontcombobox.cpp index 799d70d2b4..118e7945df 100644 --- a/src/widgets/widgets/qfontcombobox.cpp +++ b/src/widgets/widgets/qfontcombobox.cpp @@ -101,7 +101,7 @@ static QFontDatabase::WritingSystem writingSystemFromLocale() static QFontDatabase::WritingSystem writingSystemForFont(const QFont &font, bool *hasLatin) { - QList writingSystems = QFontDatabase::writingSystems(font.families().first()); + QList writingSystems = QFontDatabase::writingSystems(font.families().constFirst()); // qDebug() << font.families().first() << writingSystems; // this just confuses the algorithm below. Vietnamese is Latin with lots of special chars @@ -352,7 +352,7 @@ void QFontComboBoxPrivate::_q_updateModel() void QFontComboBoxPrivate::_q_currentChanged(const QString &text) { Q_Q(QFontComboBox); - QStringList families = currentFont.families(); + const QStringList families = currentFont.families(); if (families.isEmpty() || families.first() != text) { currentFont.setFamilies(QStringList{text}); emit q->currentFontChanged(currentFont); diff --git a/src/widgets/widgets/qkeysequenceedit.cpp b/src/widgets/widgets/qkeysequenceedit.cpp index 7ae7a048d5..0b39d5c1c6 100644 --- a/src/widgets/widgets/qkeysequenceedit.cpp +++ b/src/widgets/widgets/qkeysequenceedit.cpp @@ -344,7 +344,7 @@ void QKeySequenceEdit::keyPressEvent(QKeyEvent *e) return; if (e->modifiers() & Qt::ShiftModifier) { - QList possibleKeys = QKeyMapper::possibleKeys(e); + const QList possibleKeys = QKeyMapper::possibleKeys(e); int pkTotal = possibleKeys.size(); if (!pkTotal) return;