From dae24df07fb3db37939e9ece4cf94f223a125f16 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Sat, 24 Jun 2023 12:36:50 +0200 Subject: [PATCH] QtNetwork: code tidies: use the 4-arg connect overload MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 3-arg connect is error-prone and makes the lifetime of the connection unclear. Change-Id: I43dabe3d25ffc2b711aa50dec525d72a8810861c Reviewed-by: MÃ¥rten Nordheim --- src/network/ssl/qsslsocket.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/network/ssl/qsslsocket.cpp b/src/network/ssl/qsslsocket.cpp index 0563fd0663..9ec85c4b07 100644 --- a/src/network/ssl/qsslsocket.cpp +++ b/src/network/ssl/qsslsocket.cpp @@ -3091,10 +3091,11 @@ QTlsBackend *QSslSocketPrivate::tlsBackendInUse() tlsBackend = QTlsBackend::findBackend(activeBackendName); if (tlsBackend) { - QObject::connect(tlsBackend, &QObject::destroyed, [] { + QObject::connect(tlsBackend, &QObject::destroyed, tlsBackend, [] { const QMutexLocker locker(&backendMutex); tlsBackend = nullptr; - }); + }, + Qt::DirectConnection); } return tlsBackend; }