From dd3c4b66a1d789a468482390f56bceb22b874d2b Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 12 Aug 2021 12:06:23 +0200 Subject: [PATCH] QDir: use QStringTokenizer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Avoids having to allocate storage to hold the parts. Change-Id: Ie4d877af959751139f4c098b644e4a57f63d03b9 Reviewed-by: MÃ¥rten Nordheim Reviewed-by: Thiago Macieira --- src/corelib/io/qdir.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/corelib/io/qdir.cpp b/src/corelib/io/qdir.cpp index 639693346d..fd2f0e3067 100644 --- a/src/corelib/io/qdir.cpp +++ b/src/corelib/io/qdir.cpp @@ -177,10 +177,8 @@ inline QStringList QDirPrivate::splitFilters(const QString &nameFilter, QChar se { if (sep.isNull()) sep = getFilterSepChar(nameFilter); - const auto split = QStringView{nameFilter}.split(sep); QStringList ret; - ret.reserve(split.size()); - for (const auto &e : split) + for (auto e : qTokenize(nameFilter, sep)) ret.append(e.trimmed().toString()); return ret; }