From dd97634f80912f1c6467ea17307080bf0e4dbcdc Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Tue, 25 Nov 2014 10:22:54 +0100 Subject: [PATCH] QList::swap: implement the swap with std::swap Change-Id: Ide2f8a5581978986607de99ac9b5e9c15b3aceff Reviewed-by: Marc Mutz Reviewed-by: Olivier Goffart --- src/corelib/tools/qlist.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/corelib/tools/qlist.h b/src/corelib/tools/qlist.h index 5b459269c1..533f1d6dbc 100644 --- a/src/corelib/tools/qlist.h +++ b/src/corelib/tools/qlist.h @@ -628,9 +628,7 @@ inline void QList::swap(int i, int j) Q_ASSERT_X(i >= 0 && i < p.size() && j >= 0 && j < p.size(), "QList::swap", "index out of range"); detach(); - void *t = d->array[d->begin + i]; - d->array[d->begin + i] = d->array[d->begin + j]; - d->array[d->begin + j] = t; + std::swap(d->array[d->begin + i], d->array[d->begin + j]); } template