From e1b40675ba4adca014c45926ef29b78d22fe4833 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Thu, 31 May 2018 09:19:08 -0700 Subject: [PATCH] Fix warning about tautological comparison in 32-bit mode qwaitcondition_unix.cpp:209:14: error: comparison of constant 9223372036854775807 with expression of type 'unsigned long' is always false Task-number: QTBUG-68568 Change-Id: Icc2c231dc2c44abdb087fffd1533c70ae68060dd Reviewed-by: Liang Qi Reviewed-by: Edward Welbourne --- src/corelib/thread/qwaitcondition_unix.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/thread/qwaitcondition_unix.cpp b/src/corelib/thread/qwaitcondition_unix.cpp index 1628ede3a2..9706be1504 100644 --- a/src/corelib/thread/qwaitcondition_unix.cpp +++ b/src/corelib/thread/qwaitcondition_unix.cpp @@ -206,7 +206,7 @@ void QWaitCondition::wakeAll() bool QWaitCondition::wait(QMutex *mutex, unsigned long time) { - if (time > std::numeric_limits::max()) + if (quint64(time) > quint64(std::numeric_limits::max())) return wait(mutex, QDeadlineTimer(QDeadlineTimer::Forever)); return wait(mutex, QDeadlineTimer(time)); }