whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QString: fix premature pessimisation in arg(char-ish) 

Instead of converting the char or QChar to a QString, convert them to
a QStringView, saving the memory allocation.

Pick-to: 5.15
Change-Id: I023712ec00172f1c8570e762817bfc3a95e01125
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
bb10
Marc Mutz 2020-05-12 15:46:07 +02:00
parent 90f864a4c5
commit e201d58540
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/corelib/text/qstring.cpp
View File

@ -8684,9 +8684,7 @@ QString QString::arg(qulonglong a, int fieldWidth, int base, QChar fillChar) con
*/
QString QString::arg(QChar a, int fieldWidth, QChar fillChar) const
{
QString c;
c += a;
return arg(c, fieldWidth, fillChar);
return arg(QStringView{&a, 1}, fieldWidth, fillChar);
}
/*!
@ -8696,9 +8694,7 @@ QString QString::arg(QChar a, int fieldWidth, QChar fillChar) const
*/
QString QString::arg(char a, int fieldWidth, QChar fillChar) const
{
QString c;
c += QLatin1Char(a);
return arg(c, fieldWidth, fillChar);
return arg(QLatin1Char(a), fieldWidth, fillChar);
}
/*!