whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qtextlist::itemText: reduce allocations 

Don't create tmp QBA, just append to QString directly

Change-Id: Ib7c469ef7b9b459fbc2df662adbe613c8d74d88a
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
bb10
Anton Kudryavtsev 2023-09-10 16:16:31 +03:00
parent 60113056bc
commit e26e6d6725
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/gui/text/qtextlist.cpp
View File

@ -186,16 +186,14 @@ QString QTextList::itemText(const QTextBlock &blockIt) const
if (itemNumber < 1) {
result = QString::number(itemNumber);
} else if (itemNumber < 5000) {
QByteArray romanNumeral;
QString romanNumeral;
// works for up to 4999 items
static const char romanSymbolsLower[] = "iiivixxxlxcccdcmmmm";
static const char romanSymbolsUpper[] = "IIIVIXXXLXCCCDCMMMM";
QByteArray romanSymbols; // wrap to have "mid"
QLatin1StringView romanSymbols;
if (style == QTextListFormat::ListLowerRoman)
romanSymbols = QByteArray::fromRawData(romanSymbolsLower, sizeof(romanSymbolsLower));
romanSymbols = "iiivixxxlxcccdcmmmm"_L1;
else
romanSymbols = QByteArray::fromRawData(romanSymbolsUpper, sizeof(romanSymbolsUpper));
romanSymbols = "IIIVIXXXLXCCCDCMMMM"_L1;
int c[] = { 1, 4, 5, 9, 10, 40, 50, 90, 100, 400, 500, 900, 1000 };
int n = itemNumber;
@ -220,10 +218,10 @@ QString QTextList::itemText(const QTextBlock &blockIt) const
numDigits = q;
}
romanNumeral.append(romanSymbols.mid(startDigit, numDigits));
romanNumeral.append(romanSymbols.sliced(startDigit, numDigits));
}
}
result = QString::fromLatin1(romanNumeral);
result = std::move(romanNumeral);
} else {
result = u"?"_s;
}