From e300efe6eead71d89aeff4df135d54205a1f1b1a Mon Sep 17 00:00:00 2001 From: Mathias Hasselmann Date: Mon, 9 Feb 2015 10:10:14 +0100 Subject: [PATCH] OSX: Avoid !strcmp() anti pattern MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit People often complain that strcmp() like functions are confusing because they return false on equality and true on difference. Rightfully, because strcmp() like functions return three distinct values, not a boolean value. But I guess dear reviewer, you already know that story... Change-Id: Ie69093f61b55448010dc324d14c62faa27214238 Reviewed-by: Konstantin Ritt Reviewed-by: Tor Arne Vestbø --- src/plugins/platforms/cocoa/main.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/platforms/cocoa/main.mm b/src/plugins/platforms/cocoa/main.mm index 2293a071fc..c6e46ac28d 100644 --- a/src/plugins/platforms/cocoa/main.mm +++ b/src/plugins/platforms/cocoa/main.mm @@ -53,7 +53,7 @@ QPlatformIntegration * QCocoaIntegrationPlugin::create(const QString& system, co Q_UNUSED(paramList); QCocoaAutoReleasePool pool; - if (!system.compare(QLatin1String("cocoa"), Qt::CaseInsensitive)) + if (system.compare(QLatin1String("cocoa"), Qt::CaseInsensitive) == 0) return new QCocoaIntegration; return 0;