From e3ecabad228369bfc6dc82085446d7acc05ef45a Mon Sep 17 00:00:00 2001 From: Alexey Edelev Date: Fri, 10 Feb 2023 13:27:23 +0100 Subject: [PATCH] Avoid mapping BUILD_TESTING to QT_BUILD_TESTS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This leads to unwanted side issues such as building and running third party component tests. The option should be enabled explicitly by user instead. Fixes: QTBUG-111091 Change-Id: I8942db2bd089ad2a39a70627bfce8314b101ecb8 Reviewed-by: Kai Köhne Reviewed-by: Amir Masoud Abdol --- cmake/QtSetup.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/cmake/QtSetup.cmake b/cmake/QtSetup.cmake index cbd12e6af9..80fafe9ddf 100644 --- a/cmake/QtSetup.cmake +++ b/cmake/QtSetup.cmake @@ -223,7 +223,6 @@ if(QT_BUILD_STANDALONE_TESTS) set(QT_BUILD_TESTS_BY_DEFAULT ON CACHE BOOL "Should tests be built as part of the default 'all' target." FORCE) endif() -set(BUILD_TESTING ${QT_BUILD_TESTS} CACHE INTERNAL "") if (WASM) set(_qt_batch_tests ON)