From e61dc8a83bf56f8498f57c8e8c078ed7ff551192 Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Tue, 4 Oct 2022 18:54:50 +0200 Subject: [PATCH] Don't duplicate a column name in tst_QByteArray::movablity_data() It first added a column, then some rows, then called prependExtended_data(), which expects to be called first in a data function and starts by adding the same column. So put that first and drop the duplicate addition of the column. Change-Id: Ia5cf86f821608e78f0e4872db2b3167ef81cc59e Reviewed-by: Ivan Solovev Reviewed-by: Marc Mutz --- tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp b/tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp index 9096c6319a..7e2b0e6545 100644 --- a/tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp +++ b/tests/auto/corelib/text/qbytearray/tst_qbytearray.cpp @@ -2129,7 +2129,7 @@ void tst_QByteArray::resize() void tst_QByteArray::movablity_data() { - QTest::addColumn("array"); + prependExtended_data(); QTest::newRow("0x00000000") << QByteArray("\x00\x00\x00\x00", 4); QTest::newRow("0x000000ff") << QByteArray("\x00\x00\x00\xff", 4); @@ -2137,8 +2137,6 @@ void tst_QByteArray::movablity_data() QTest::newRow("empty") << QByteArray(""); QTest::newRow("null") << QByteArray(); QTest::newRow("sss") << QByteArray(3, 's'); - - prependExtended_data(); } void tst_QByteArray::movablity()