From e8aa70c2d61c1ecaa17202967ac27be631d1a434 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Sun, 7 Sep 2014 21:21:27 +0200 Subject: [PATCH] QFileSelector: use qEnvironmentVariableIsEmpty() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It doesn't allocate memory, so cannot throw and is a lot faster than qgetenv(). Change-Id: Ib303f00ce45816677ffca0580cc6b91a14a0e5be Reviewed-by: Jędrzej Nowacki --- src/corelib/io/qfileselector.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/io/qfileselector.cpp b/src/corelib/io/qfileselector.cpp index 639310876a..7b8f762031 100644 --- a/src/corelib/io/qfileselector.cpp +++ b/src/corelib/io/qfileselector.cpp @@ -343,7 +343,7 @@ void QFileSelectorPrivate::updateSelectors() if (envSelectors.count()) sharedData->staticSelectors << envSelectors; - if (!qgetenv(env_override).isEmpty()) + if (!qEnvironmentVariableIsEmpty(env_override)) return; sharedData->staticSelectors << sharedData->preloadedStatics; //Potential for static selectors from other modules