From ed05ef77587580bb291c7c1bebeb188fc9a3d883 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Tue, 26 Jan 2021 12:43:44 +0100 Subject: [PATCH] Fix static analysis warnings concerning QNetworkInformation By marking undeclared and unused copy/move constructors as deleted. Change-Id: Ie74b9cb015090dbb425b701a55eadb9d80ab0285 Reviewed-by: Edward Welbourne --- src/network/kernel/qnetworkinformation.h | 2 ++ src/network/kernel/qnetworkinformation_p.h | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/src/network/kernel/qnetworkinformation.h b/src/network/kernel/qnetworkinformation.h index 6321300f40..eddabc9707 100644 --- a/src/network/kernel/qnetworkinformation.h +++ b/src/network/kernel/qnetworkinformation.h @@ -89,6 +89,8 @@ Q_SIGNALS: private: friend class QNetworkInformationPrivate; QNetworkInformation(QNetworkInformationBackend *backend); + + Q_DISABLE_COPY_MOVE(QNetworkInformation) }; QT_END_NAMESPACE diff --git a/src/network/kernel/qnetworkinformation_p.h b/src/network/kernel/qnetworkinformation_p.h index fc783fa079..389310cc43 100644 --- a/src/network/kernel/qnetworkinformation_p.h +++ b/src/network/kernel/qnetworkinformation_p.h @@ -63,6 +63,7 @@ class Q_NETWORK_EXPORT QNetworkInformationBackend : public QObject { Q_OBJECT public: + QNetworkInformationBackend() = default; virtual ~QNetworkInformationBackend(); virtual QString name() const = 0; @@ -83,6 +84,7 @@ protected: private: QNetworkInformation::Reachability m_reachability = QNetworkInformation::Reachability::Unknown; + Q_DISABLE_COPY_MOVE(QNetworkInformationBackend) friend class QNetworkInformation; friend class QNetworkInformationPrivate; }; @@ -96,6 +98,9 @@ public: virtual QString name() const = 0; virtual QNetworkInformationBackend *create(QNetworkInformation::Features requiredFeatures) const = 0; virtual QNetworkInformation::Features featuresSupported() const = 0; + +private: + Q_DISABLE_COPY_MOVE(QNetworkInformationBackendFactory) }; #define QNetworkInformationBackendFactory_iid "org.qt-project.Qt.NetworkInformationBackendFactory" Q_DECLARE_INTERFACE(QNetworkInformationBackendFactory, QNetworkInformationBackendFactory_iid);