whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tst_QFile: distinguish invalid from valid in mapResource data-tags 

The test was using the same tags twice each, giving no clue to the
difference between the two test-cases for each.

Change-Id: I645b01c0c4008a766e505047cb05cc22640ee129
Reviewed-by: Dimitrios Apostolou <jimis@qt.io>
bb10
Edward Welbourne 2022-10-05 11:49:31 +02:00
parent 50561716f0
commit ef8905aa2b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/auto/corelib/io/qfile/tst_qfile.cpp
View File

@ -3274,13 +3274,15 @@ void tst_QFile::mapResource_data()
QString validFile = ":/tst_qfileinfo/resources/file1.ext1";
QString invalidFile = ":/tst_qfileinfo/resources/filefoo.ext1";
const char modes[] = "invalid";
for (int i = 0; i < 2; ++i) {
QString file = (i == 0) ? validFile : invalidFile;
QTest::newRow("0, 0") << 0 << 0 << QFile::UnspecifiedError << file;
QTest::newRow("0, BIG") << 0 << 4096 << QFile::UnspecifiedError << file;
QTest::newRow("-1, 0") << -1 << 0 << QFile::UnspecifiedError << file;
QTest::newRow("0, -1") << 0 << -1 << QFile::UnspecifiedError << file;
const char *mode = i == 0 ? modes + 2 : modes;
QTest::addRow("0, 0 (%s)", mode) << 0 << 0 << QFile::UnspecifiedError << file;
QTest::addRow("0, BIG (%s)", mode) << 0 << 4096 << QFile::UnspecifiedError << file;
QTest::addRow("-1, 0 (%s)", mode) << -1 << 0 << QFile::UnspecifiedError << file;
QTest::addRow("0, -1 (%s)", mode) << 0 << -1 << QFile::UnspecifiedError << file;
}
QTest::newRow("0, 1") << 0 << 1 << QFile::NoError << validFile;