From efb5424800c43ac57287f56fc27458579ef2ddbe Mon Sep 17 00:00:00 2001 From: Anton Kudryavtsev Date: Fri, 25 Aug 2023 18:33:01 +0300 Subject: [PATCH] QAuthenticator: postpone creation of QBA MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Create QBA only when it's needed While touching code, use std::move more Change-Id: I5f014822a47d41fa1fca46a85a7921c70d1d9a55 Reviewed-by: Mårten Nordheim --- src/network/kernel/qauthenticator.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/kernel/qauthenticator.cpp b/src/network/kernel/qauthenticator.cpp index 432dfa7877..ba1abca830 100644 --- a/src/network/kernel/qauthenticator.cpp +++ b/src/network/kernel/qauthenticator.cpp @@ -664,7 +664,7 @@ QAuthenticatorPrivate::parseDigestAuthenticationChallenge(QByteArrayView challen const char *start = d; while (d < end && *d != '=') ++d; - QByteArray key = QByteArray(start, d - start); + QByteArrayView key = QByteArrayView(start, d - start); ++d; if (d >= end) break; @@ -695,7 +695,7 @@ QAuthenticatorPrivate::parseDigestAuthenticationChallenge(QByteArrayView challen while (d < end && *d != ',') ++d; ++d; - options[key] = value; + options[key.toByteArray()] = std::move(value); } QByteArray qop = options.value("qop");