From f849583e844daa6e2e51722562c43ea5cbb60d74 Mon Sep 17 00:00:00 2001 From: Giuseppe D'Angelo Date: Tue, 2 Sep 2014 16:50:11 +0200 Subject: [PATCH] QSslSocket: remove a useless assignment I was actually wondering if the test always succeeds (i.e. should be turned into a Q_ASSERT), but I don't know the codebase enough to justify such a change. Change-Id: Id01b8de7244428e9b1c240dc365c66eeef0d6111 Reviewed-by: Marc Mutz Reviewed-by: Andrew Knight --- src/network/ssl/qsslsocket.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/network/ssl/qsslsocket.cpp b/src/network/ssl/qsslsocket.cpp index b092e5e980..d584c28e15 100644 --- a/src/network/ssl/qsslsocket.cpp +++ b/src/network/ssl/qsslsocket.cpp @@ -2135,10 +2135,8 @@ void QSslConfigurationPrivate::deepCopyDefaultConfiguration(QSslConfigurationPri QMutexLocker locker(&globalData()->mutex); const QSslConfigurationPrivate *global = globalData()->config.constData(); - if (!global) { - ptr = 0; + if (!global) return; - } ptr->ref.store(1); ptr->peerCertificate = global->peerCertificate;