From f95d6bb09de5c3a8e4d8b3de2e791ea73ec60d93 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Thu, 11 Mar 2021 13:44:30 -0800 Subject: [PATCH] tst_QProcess: increase wait time and remove ill-advised QCOMPARE The QCOMPARE made dead code of a more verbose QVERIFY2 below Change-Id: I26b8286f61534f88b649fffd166b67d8603280a7 Reviewed-by: Oswald Buddenhagen --- tests/auto/corelib/io/qprocess/tst_qprocess.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/auto/corelib/io/qprocess/tst_qprocess.cpp b/tests/auto/corelib/io/qprocess/tst_qprocess.cpp index 035c5941c2..fad0277821 100644 --- a/tests/auto/corelib/io/qprocess/tst_qprocess.cpp +++ b/tests/auto/corelib/io/qprocess/tst_qprocess.cpp @@ -1145,9 +1145,8 @@ void tst_QProcess::forwardedChannels() QVERIFY(process.waitForStarted(5000)); QCOMPARE(process.write("input"), 5); process.closeWriteChannel(); - QVERIFY(process.waitForFinished(5000)); + QVERIFY(process.waitForFinished(40000)); // testForwarding has a 30s wait QCOMPARE(process.exitStatus(), QProcess::NormalExit); - QCOMPARE(process.exitCode(), 0); const char *err; switch (process.exitCode()) { case 0: err = "ok"; break;