Commit Graph

3539 Commits (7feaf9d41ed962dba04ce29d3a285c54ed04e9fc)

Author SHA1 Message Date
Frédéric Lefebvre 7feaf9d41e tst_QGroupBox::propagateFocus() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I2bcad29de4bcbb90a1e891a2f39db966288abdb1
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-06 16:29:02 +02:00
Frédéric Lefebvre 8b3620c93d taskQTBUG_5008_textFromValueAndValidate() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I472e5648f9ea7ba699477d44b2a67500af371410
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-06 16:29:02 +02:00
Frédéric Lefebvre 2e3f607aae tst_QStackedLayout::keepFocusAfterSetCurrent() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Iaf1e79193f0f7013d02d91930cc408af5b0f8e1d
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-06 16:29:02 +02:00
Frédéric Lefebvre 0581f59deb tst_QStackedWidget::dynamicPages() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: If6d2bbde186d21662bf9a72b0b03152317724f01
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-06 16:29:02 +02:00
Frédéric Lefebvre f9751fe13f tst_QGraphicsProxyWidget::actionsContextMenu() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ib33b6d750a409e5a374fcbb42dbba646582be8a7
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-06 11:28:15 +02:00
Frédéric Lefebvre d8a022eec4 taskQTBUG_5008_textFromValueAndValidate() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ifec63ae2fcacdc37096e55f096def8c90a7b75ab
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-06 11:15:04 +02:00
Frédéric Lefebvre 18379e5fd7 tst_QSpinBox::specialValue remove QApplicationPrivate::setActiveWindow
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ifea4bfa00cee9c4b15bc8ca7659d5f23d66c87d4
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-06 11:15:01 +02:00
Frédéric Lefebvre ccbff2c08b setFocus_simpleTwoWidgets() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I5161f63321d586e72787eee5101329746f03dde1
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-03 20:53:33 +02:00
Frédéric Lefebvre b64932ba82 tst_QApplication::alert() remove QApplicationPrivate::setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I208ad97d7b56ded15908b96ad03779db849ef6a9
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-03 17:11:23 +02:00
Frédéric Lefebvre 3d19633f5d bypassGraphicsProxyWidget() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I0a657c9aaac4684566edd212a510c7c9016117a2
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-03 14:04:52 +02:00
Axel Spoerl f97e60a4f0 Fix crash in QMainWindow:.tabifiedDockWidgets()
QMainWindow:.tabifiedDockWidgets() was refactored in Qt 6.6.3, because
it returned wrong values. It now loops from 0 to
QMainWindowTabBar::count() and uses QMainWindowTabBar::dockAt(), to
get the dock widget pointer for an index.

When a dock widget is removed from a floating tab, event processing is
necessary for the item_list and QMainWindowTabBar::count() to get in
sync. This case was overlooked in the refactoring. It can lead to
dockAt() being called with an out-of-bounds index, which it asserted.
The assertion triggered, when QMainWindow::removeDockWidget() and
QMainWindow::tabifiedDockWidgets() were called right after each other,
without processing events inbetween.

QMainWindowTabBar::dockWidgets() doesn't add nullptr to the list, it
returns.

Therefore, return nullptr, when dockAt() is called out-of-bounds.
Add test functionality in
tst_QDockWidget::updateTabBarOnVisibilityChanged().

Fixes: QTBUG-124262
Pick-to: 6.7 6.5
Change-Id: If66084b9f00b4e39f7a620da68df67c735029cf1
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2024-05-02 20:11:44 +00:00
Frédéric Lefebvre 0c52e694e2 tst_QToolBar::accel() remove QApplicationPrivate::setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ic729e2675a6a51531b4ee055d2d0b84866331b28
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-02 18:14:56 +02:00
Frédéric Lefebvre 8a4728c1b9 setFocus_complexTwoWidgets() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I362ddbc98f864b5bae37d6e98dc5d9a3144848b5
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-05-02 12:47:09 +02:00
Frédéric Lefebvre 9df78efbd1 taskQTBUG11823_crashwithInvisibleActions() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I1ac84b3166bb17e120b0c38b7d164f2e4e412e6d
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:57 +02:00
Frédéric Lefebvre 3b5f31a80c tst_QMenuBar::task256322_highlight() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I2cb6b63e1ecdfd1e10d04baf5970236d31781d3e
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:57 +02:00
Frédéric Lefebvre f515b53493 tst_QMenuBar::check_menuPosition() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I2e8e1e8b2809937e3f7c1e5362afb037d953c950
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:57 +02:00
Frédéric Lefebvre 9ec05ffb13 tst_QMenuBar::check_shortcutPress() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number:  QTBUG-121488
Change-Id: I569d6316f3fa7b7131ce3c8448784f0588008a2c
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:57 +02:00
Frédéric Lefebvre 48083186a1 tst_QMenuBar::check_altClosePress() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I7c949c9d279aea52ee774db65d9cf0033ac60fef
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:57 +02:00
Frédéric Lefebvre 9d9d7ad5b8 tst_QMenuBar::check_altPress() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I43e3a097e59f9c14ec2f599b12b707a2fcf98b36
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:57 +02:00
Frédéric Lefebvre 4da4273743 tst_QMenuBar::check_escKey remove QApplicationPrivate::setActiveWindow
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ib9f5844c79f37f0992076060548c30d80d20e323
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:57 +02:00
Frédéric Lefebvre 7c5f7efeb7 tst_QMenuBar::taskQTBUG56860_focus() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I96178f118ab5d60d23047a01c884a9cddcf213d5
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:57 +02:00
Frédéric Lefebvre 481a8f4802 tst_QMenuBar::check_cursorKeys3() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number:  QTBUG-121488
Change-Id: Id7db0930ebac72bf2ddebffa9f991949ba515974
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:56 +02:00
Frédéric Lefebvre b200a40b35 tst_QMenuBar::check_cursorKeys2() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I570eefc39dcd5bcf8cc3673d1898f01c4dc5725f
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:56 +02:00
Frédéric Lefebvre 8428ca01a3 QTBUG14363_completerWithAnyKeyPressedEditTriggers remove setActiveWindo
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I2f67811f95f580b67f247df55020266ec28c13a7
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:22 +02:00
Frédéric Lefebvre a628a5805f tst_QTableView::keyboardNavigation() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ia26ea1623a00f17765d5530882dd83480e3bb9b8
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:21 +02:00
Frédéric Lefebvre 611a89498f tst_QMdieArea::subWindowList() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I846682ed9b04b72867ffa85b0e4fc000b29c38ac
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:21 +02:00
Frédéric Lefebvre d012310622 tst_QGraphicsProxyWidget::clickFocus() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Icf9c4b1378eb244edb56f900ba74469abc38314f
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:21 +02:00
Frédéric Lefebvre 9aaf451a1e QTBUG_6986_sendMouseEventToAlienWidget() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: If5ddc863411907793be3a8d7b226ee49b606e9e8
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:21 +02:00
Frédéric Lefebvre 16a34dbedf tst_QGraphicsProxyWidget::mapToGloval() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ib5f081fb03e3abd8cb8492a6d673ade98762e26a
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:21 +02:00
Frédéric Lefebvre 36c79773aa tst_QDateTimeEdit::displayFormat() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I5770bebfa4e2219d511ef8e1396ad550b1ba7b41
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:21 +02:00
Frédéric Lefebvre d0b0feb76b tst_QDateTimeEdit::backspaceKey() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ia2524280d57286ac53c684b53f9bee6c6c85b8c1
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:21 +02:00
Frédéric Lefebvre 8c0c880123 tst_QDateTimeEdit::deleteKey() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I49a6202e22246f9bf724636badbd87d9fb40d49d
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:21 +02:00
Frédéric Lefebvre 20e824f83f tst_QDateTimeEdit::tabKeyNavigation() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ic3425eecedffe0def3aa851157aedc4231dca1e9
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:28:20 +02:00
Frédéric Lefebvre 5be227b924 tabFocus_complexTwoWidgets() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I60c873e4df7f5183bd1a9f295f6e916d224b6794
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:17:03 +02:00
Frédéric Lefebvre 9da124b01b tst_QGraphicsProxyWidget::tabFocus_complexWidget remove setActiveWindow
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ie8496d0dc8ff0f1e085c7f218a07dd2c42e4fc14
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:17:03 +02:00
Frédéric Lefebvre 1a9bd89788 tabFocus_simpleTwoWidgets() remove setActiveWindow()
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I71c2b7a6ef69bb2990b8d56020323b90c949f966
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:17:03 +02:00
Frédéric Lefebvre 43c7c4080b tst_QGraphicsProxyWidget::tabFocus_simpleWidget remove setActiveWindow
2f6fe3a268 has made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I5dacd3971305e33a6d1314b798d4211425b68d68
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 21:17:03 +02:00
Eike Ziller 24859d7dea QCompleter: Hide popup when widget is hidden
When the widget the completer is attached to was hidden,
the popup stayed open. It would "hang around" with no
corresponding UI being around anymore, which is weird.

Fixes: QTBUG-124861
Pick-to: 6.7
Change-Id: If9cb04e693c2663ef9da14164611f26becafc4b4
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
2024-04-30 16:30:16 +00:00
Frédéric Lefebvre ec449a8379 tst_QAction::disableShortcutsWithBlockedWidgets remove setActiveWindow
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Iea02f308c3357ddcb8f52527031b9417d8a175d7
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 18:30:16 +02:00
Frédéric Lefebvre 800024a42a tst_QAction::repeat() remove QApplicationPrivate::setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I845a0a9220bca176f9c270cb7aee225325c2e7af
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 18:30:16 +02:00
Frédéric Lefebvre 77acde40c1 tst_QAction::actionEvent() remove QApplicationPrivat::setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I8e58e26382dfc32e0a3475dd601c0377e7378d87
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 18:30:16 +02:00
Frédéric Lefebvre 55fd2c9c70 textEditDoesntChangeFocusOnTab_qtbug3305() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ieb302b451308c3e486c6d8adca17b173da5db347
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 18:30:15 +02:00
Frédéric Lefebvre cbfc2d65a1 tst_QMenuBar::taskQTBUG55966_subMenuRemoved() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I69256675a33df73ac98fc4025b6d1e915e91b386
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 18:30:15 +02:00
Frédéric Lefebvre 835598e20d taskQTBUG46812_doNotLeaveMenubarHighLighted() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Iacaf59536ed01e34ed933976b53228a3bd2b22f1
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 18:30:15 +02:00
Frédéric Lefebvre 85543ed012 QTBUG_25669_menubarActionDoubleTriggered() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I0ac3813a5082af9ca86e6d5fa746685f12e6389d
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 17:46:34 +02:00
Frédéric Lefebvre 2cc92f6eda tst_QMenuBar::QTBUG_65488_hiddenActionTriggered remove setActiveWindow
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Ie5e5ecb8616201fc3efd783c660af53744048767
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 17:46:34 +02:00
Frédéric Lefebvre ee9af0542e taskQTBUG53205_crashReparentNested() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I5daca4f335333394fa324d0c800fb20dae0d9909
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 17:46:34 +02:00
Frédéric Lefebvre 76087c8717 closeOnSecondClickAndOpenOnThirdClick() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: Id7e9fa632dda54c873881c9c5385cfab5158bc1f
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 17:46:34 +02:00
Frédéric Lefebvre 9ed9ef5502 tst_QMenuBar::check_cursorKeys1() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I1bdcc0c70ccb88b0c66d226bfcf83a031add56af
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 10:19:25 +02:00
Frédéric Lefebvre 0a81237064 tst_QMenuBar::check_accelKeys() remove setActiveWindow()
2f6fe3a268 as made calls to
QApplicationPrivate::setActiveWindow() redundant.

Remove redundant calls.

Task-number: QTBUG-121488
Change-Id: I1ee591c0677e466c80ac0f8283fad4c4161aa195
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
2024-04-30 10:19:25 +02:00