7706c2a28e
When using the cosmetic stroker (i.e. plain pens with effective line width of 1), drawing points with fractional coordinates >= 0.5 would fill the wrong pixel. This is a long-standing bug where the drawPoints() code in the cosmetic stroker code was missed during the painting coordinate system shift for Qt 5.0. Prior to that, coordinates were interpreted as the upper left corner of a pixel, so rounding fractional coordinates to the closest integer would be the correct way to determine the pixel to be filled. From Qt 5 onwards however, coordinates instead designate the center point of the primitive to be stroked. In order to determine which pixel is most covered by the unit square centered in the given coordinates, fractional coordinates must be rounded downwards (floored). This fix makes the behavior consistent between the cosmetic and non-cosmetic stroker, so that drawPoints() with e.g. penwidths 1 and 1.01 in practice fills the same pixels. Pick-to: 6.6 Fixes: QTBUG-119306 Change-Id: I39cb7ad55229553dda098e6fbc9ee449b1fd9664 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> |
||
|---|---|---|
| .. | ||
| aliasing.qps | ||
| arcs.qps | ||
| arcs2.qps | ||
| background.qps | ||
| background_brush.qps | ||
| beziers.qps | ||
| bitmaps.qps | ||
| borderimage.qps | ||
| brush_pens.qps | ||
| brushes.qps | ||
| clippath_antialiasing.qps | ||
| clippaths.qps | ||
| clipping.qps | ||
| clipping_state.qps | ||
| cliprects.qps | ||
| conical_gradients.qps | ||
| conical_gradients_perspectives.qps | ||
| cosmetic.qps | ||
| dashes.qps | ||
| degeneratebeziers.qps | ||
| deviceclipping.qps | ||
| drawpoints.qps | ||
| ellipses.qps | ||
| fillrect.qps | ||
| fillrect_aa.qps | ||
| filltest.qps | ||
| glyphruns.qps | ||
| gradients.qps | ||
| gradientxform_device.qps | ||
| gradientxform_logical.qps | ||
| gradientxform_object.qps | ||
| hinting.qps | ||
| image_dpr.qps | ||
| image_formats.qps | ||
| images.qps | ||
| images2.qps | ||
| join_cap_styles.qps | ||
| join_cap_styles_duplicate_control_points.qps | ||
| linear_gradients.qps | ||
| linear_gradients_perspectives.qps | ||
| linear_resolving_gradients.qps | ||
| lineconsistency.qps | ||
| linedashes.qps | ||
| linedashes2.qps | ||
| linedashes2_aa.qps | ||
| lines.qps | ||
| lines2.qps | ||
| lines3.qps | ||
| pathfill.qps | ||
| paths.qps | ||
| paths_aa.qps | ||
| pattern_xform.qps | ||
| pattern_xform2.qps | ||
| pens.qps | ||
| pens_aa.qps | ||
| pens_cosmetic.qps | ||
| perspectives.qps | ||
| perspectives2.qps | ||
| pixmap_rotation.qps | ||
| pixmap_rotation2.qps | ||
| pixmap_scaling.qps | ||
| pixmap_subpixel.qps | ||
| pixmapfragments.qps | ||
| pixmaps.qps | ||
| porter_duff.qps | ||
| porter_duff2.qps | ||
| primitives.qps | ||
| radial_gradients.qps | ||
| radial_gradients_perspectives.qps | ||
| rasterops.qps | ||
| richtext.qps | ||
| sizes.qps | ||
| smallcaps_path.qps | ||
| statictext.qps | ||
| text.qps | ||
| text_perspectives.qps | ||
| thinlines.qps | ||
| tiled_pixmap.qps | ||
| tinydashes.qps | ||