The logic in the isValidSegment() function was failing for 8-bit signed because for them Integer(SegmentUnknown) is -1, so (std::numeric_limits<Integer>::max)() < Integer(SegmentUnknown) was always false (127 < -1) and the function would only return true on the impossible condition of segment >= 0 && segment < -1 Fixes: QTBUG-128848 Pick-to: 6.7 6.5 Change-Id: I8d17b93afd6c2982a099fffdcaeccf126b7a9d02 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit ddfcc0734875cdee2c169bf2ecb1546bddba6e98) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> |
||
|---|---|---|
| .. | ||
| auto | ||
| baseline | ||
| benchmarks | ||
| global | ||
| libfuzzer | ||
| manual | ||
| shared | ||
| testserver | ||
| CMakeLists.txt | ||
| README | ||
README
This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.
Linux X11:
* The user must be logged in to an active desktop; you can't run the
autotests without a valid DISPLAY that allows X11 connections.
* The tests are run against a KDE3 or KDE4 desktop.
* Window manager uses "click to focus", and not "focus follows mouse". Many
tests move the mouse cursor around and expect this to not affect focus
and activation.
* Disable "click to activate", i.e., when a window is opened, the window
manager should automatically activate it (give it input focus) and not
wait for the user to click the window.