Thiago Macieira 4368179c37 QTimer: fix regression on singleShot-invoking non-mormalized SLOT()s ... The was introduced with the rewrite of QMetaObject::invokeMethod() in commit 0f76e55bc4, because we have an optimization for zero timers to avoid creating a temporary QSingleShotTimer object. The old implementation did attempt to normalize the target slot name, but did so because it looked metamethods up using QMetaObject::indexOfMethod: int idx = meta->indexOfMethod(sig.constData()); if (idx < 0) { QByteArray norm = QMetaObject::normalizedSignature(sig.constData()); idx = meta->indexOfMethod(norm.constData()); } The new implementation does not use this method so it didn't need to attempt to normalize. I am fixing this only in QTimer and not in QMetaObject::invokeMethodImpl (even though it is trivial to do so) because I don't believe spaces in a pure string to invokeMethod were ever expected to work: QMetaObject::invokeMethod(obj, "slotName ", Qt::QueuedConnection); The Q_ARG and Q_RETURN_ARG (for code not recompiled) still does normalization inside QMetaType::fromName(). Fixes: QTBUG-116060 Pick-to: 6.5 6.6 Change-Id: I964c2b1e6b834feb9710fffd177cac60c83ef413 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>		2023-08-22 10:17:33 -07:00
..
.gitignore	Moving relevant tests to corelib/kernel	2011-09-01 12:42:14 +02:00
BLACKLIST	Fix tst_qtimer::zeroTimer unit test	2020-11-01 01:28:55 +02:00
CMakeLists.txt	CMake: Make corelib tests standalone projects	2023-07-05 15:09:32 +02:00
tst_qtimer.cpp	QTimer: fix regression on singleShot-invoking non-mormalized SLOT()s	2023-08-22 10:17:33 -07:00