The test had some shortcomings: - Flakyness due to not waiting for the file dialog list to be populated. - It assumed that the hardcoded directory name ____aaaa... always would show first in the list. This may not be true on Windows, where names like .designer show above. - On failure, the test directory would leak. This manifested in failures like: FAIL! : tst_QFiledialog::clearLineEdit() '(fd.directory().absolutePath() != QDir::home().absolutePath())' returned FALSE. () To fix this, use QTemporaryDir and introduce predicates that can be used to check whether the dialog has been populated and the right file/directory is selected by pressing cursor down. Use the temporary directory as not to pollute the home directory. Change-Id: Ic504b91325993dcd6099c99e125e7ed8ff1d7672 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: David Faure <david.faure@kdab.com> |
||
|---|---|---|
| .. | ||
| qcolordialog | ||
| qdialog | ||
| qerrormessage | ||
| qfiledialog | ||
| qfiledialog2 | ||
| qfilesystemmodel | ||
| qfontdialog | ||
| qinputdialog | ||
| qmessagebox | ||
| qprogressdialog | ||
| qsidebar | ||
| qwizard | ||
| dialogs.pro | ||