We want to avoid caling toMSecsSinceEpoch() since it's expensive for LocalTime (which is presumed to be the common case). We can do so when both sides have the same offset from UTC (and this can cheaply be determined) but that's no help for two local times months apart, one in DST the other not. However, in this case, the difference in millis is big enough that no plausible difference in offset can overcome it, so we can again avoid toMSecsSinceEpoch() and simply compare millis. This should make some previously-expensive comparisons cheap. Add test-cases to the QDateTime ordering test that verify this doesn't lead to mis-comparison at the biggest offset-difference known. Fixes: QTBUG-131491 Change-Id: I1afd5d058c8663c908f898d4c50d0837549b87db Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de> (cherry picked from commit ef540d77751e24fe0b345694f43cdafca3434c68) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> |
||
|---|---|---|
| .. | ||
| auto | ||
| baseline | ||
| benchmarks | ||
| global | ||
| libfuzzer | ||
| manual | ||
| shared | ||
| testserver | ||
| CMakeLists.txt | ||
| README | ||
README
This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.
Linux X11:
* The user must be logged in to an active desktop; you can't run the
autotests without a valid DISPLAY that allows X11 connections.
* The tests are run against a KDE3 or KDE4 desktop.
* Window manager uses "click to focus", and not "focus follows mouse". Many
tests move the mouse cursor around and expect this to not affect focus
and activation.
* Disable "click to activate", i.e., when a window is opened, the window
manager should automatically activate it (give it input focus) and not
wait for the user to click the window.