This removes the TODO that was left in the file. It's also applied for
bootstrapped use of QAnyStringView, even though it's currently not used
in the bootstrap lib.
Along with the previous commit of inverting the order of the members,
the code generated by GCC 12 for a visitation compares as:
_Z1f14QAnyStringView: _Z1f14QAnyStringView:
movabsq $4611686018427387903, %rcx | movq %rsi, %rax
movq %rdi, %rdx | shrq $2, %rsi
movabsq $-4611686018427387904, %rax | andl $3, %eax
andq %rsi, %rax | cmpq $2, %rax
andq %rcx, %rsi <
movabsq $-9223372036854775808, %rcx <
cmpq %rcx, %rax <
je .L15 je .L15
movabsq $4611686018427387904, %rcx | cmpq $1, %rax
cmpq %rcx, %rax <
je .L16 je .L16
jmp _Z1fI20QBasicUtf8StringViewILb0EEEvT_ jmp _Z1fI20QBasicUtf8StringViewILb0EEEvT_
.L16: .L16:
movq %rsi, %rdi | jmp _Z1fI17QLatin1StringViewEvT_
movq %rdx, %rsi <
jmp _Z1fI13QLatin1StringEvT_ <
.L15: .L15:
movq %rsi, %rdi <
movq %rdx, %rsi <
jmp _Z1fI11QStringViewEvT_ jmp _Z1fI11QStringViewEvT_
Fixes: QTBUG-109086
Change-Id: I51d12ccdc56c4ad2af07fffd172db128ca4105a5
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
|
||
|---|---|---|
| .github/workflows | ||
| LICENSES | ||
| bin | ||
| cmake | ||
| coin | ||
| config.tests | ||
| dist | ||
| doc | ||
| examples | ||
| lib | ||
| libexec | ||
| mkspecs | ||
| qmake | ||
| src | ||
| tests | ||
| util | ||
| .cmake.conf | ||
| .gitattributes | ||
| .gitignore | ||
| .lgtm.yml | ||
| .tag | ||
| CMakeLists.txt | ||
| conanfile.py | ||
| config_help.txt | ||
| configure | ||
| configure.bat | ||
| configure.cmake | ||
| dependencies.yaml | ||
| qt_cmdline.cmake | ||
| sync.profile | ||