Volker Hilsheimer c95de359b4 QComboBox: Don't dereference potential nullptr, simplify ... Amends a874087504, which tested whether d->container is nullptr to decide whether to hide the popup, and then dereferences d->container later without checking again. This raised a correct static analyzer warning. Simplify that logic. hidePopup() does nothing if there is no visible container, and we don't want to accept() the cancel key if there isn't. So the closeOnCancel logic isn't actually needed, we only need to accept the ShortcutOverride to make sure that QComboBox sees the Cancel key even if there is a shortcut registered, and then we can handle and accept the cancel key to call hidePopup() only if the popup is visible. Add test to verify that this interaction works as expected. Pick-to: 6.4 Task-number: QTBUG-108908 Change-Id: I60d92b068f0f5139d629cf4a58e225512170df77 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>		2022-12-08 15:14:17 +01:00
..
.gitignore	…
BLACKLIST	qtbase: cleanup BLACKLIST files	2018-02-13 15:20:33 +00:00
CMakeLists.txt	Change the license of all CMakeLists.txt and *.cmake files to BSD	2022-08-23 23:58:42 +02:00
qtlogo.png	Fix QComboBox icon testing	2012-10-16 10:47:41 +02:00
qtlogoinverted.png	Purge sRGB chunks from PNGs in tests.	2016-03-29 08:39:43 +00:00
tst_qcombobox.cpp	QComboBox: Don't dereference potential nullptr, simplify	2022-12-08 15:14:17 +01:00