8b9346c740
This may result in incrementing an invalid iterator after the
iterator's container has changed. Also, for this to happen,
the view needs to have an active editor.
The reentrant call happens as follows in QTreeView, after the
model adds new rows to the view:
QTreeView::rowsInserted()
QAbstractItemView::rowsInserted()
QAbstractItemView::updateEditorGeometries()
QTreeView::visualRect()
QAbstractItemViewPrivate::executePostedLayout()
QTreeView::doItemsLayout()
QAbstractItemView::doItemsLayout()
QTreeView::updateGeometries()
QAbstractItemView::updateGeometries()
QAbstractItemView::updateEditorGeometries()
Other concrete item view classes may be prone to the same issue.
The fix consists in relayouting the items if needed, which should
trigger calling updateEditorGeometries() again. This doesn't
invalidate previous optimizations regarding item relayouting since
we only force relayouting when it'll be done by visualRect().
Change-Id: Id31507fdc8d9a84d50265298191d690d1a06792b
Task-number: QTBUG-48968
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
|
||
|---|---|---|
| .. | ||
| qabstractitemview | ||
| qcolumnview | ||
| qdatawidgetmapper | ||
| qdirmodel | ||
| qfileiconprovider | ||
| qheaderview | ||
| qitemdelegate | ||
| qitemeditorfactory | ||
| qitemview | ||
| qlistview | ||
| qlistwidget | ||
| qtableview | ||
| qtablewidget | ||
| qtreeview | ||
| qtreewidget | ||
| qtreewidgetitemiterator | ||
| itemviews.pro | ||