whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qtextformat: port while loops to range for 

to improve readability

Change-Id: I11b44154d8db35b93a887bb4797af9a985749f24
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
bb10
Anton Kudryavtsev 2023-10-12 16:36:35 +03:00
parent b90b624ce0
commit 2dce499561
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/gui/text/qtextformat.cpp
View File

@ -2242,13 +2242,8 @@ void QTextBlockFormat::setTabPositions(const QList<QTextOption::Tab> &tabs)
{
QList<QVariant> list;
list.reserve(tabs.size());
QList<QTextOption::Tab>::ConstIterator iter = tabs.constBegin();
while (iter != tabs.constEnd()) {
QVariant v;
v.setValue(*iter);
list.append(v);
++iter;
}
for (const auto &e : tabs)
list.append(QVariant::fromValue(e));
setProperty(TabPositions, list);
}
@ -2264,13 +2259,10 @@ QList<QTextOption::Tab> QTextBlockFormat::tabPositions() const
if (variant.isNull())
return QList<QTextOption::Tab>();
QList<QTextOption::Tab> answer;
QList<QVariant> variantsList = qvariant_cast<QList<QVariant> >(variant);
QList<QVariant>::Iterator iter = variantsList.begin();
const QList<QVariant> variantsList = qvariant_cast<QList<QVariant> >(variant);
answer.reserve(variantsList.size());
while(iter != variantsList.end()) {
answer.append( qvariant_cast<QTextOption::Tab>(*iter));
++iter;
}
for (const auto &e: variantsList)
answer.append(qvariant_cast<QTextOption::Tab>(e));
return answer;
}