whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QSslDiffieHellmanParameters_dummy - remove Q_UNIMPLEMENTED 

As a part of SSL initialization (done by QNAM on the first HTTP get request,
for example), 'dummy'  Diffie/Hellman parameter's mem-functions constantly
and unconditionally print  'Unimplemented code' even without user
actually calling these unimplemented methods. This is not just annoying,
(just realized I saw this 'Unimplemented code' many times today) this also breaks several
our auto-tests (xmlpatterns/qquickimage for example) - the ones that expect output
to be empty.

Task-number: QTBUG-55003
Change-Id: I5e4822e9783de32aa4b00843a9916eafea3689c0
Reviewed-by: Richard J. Moore <rich@kde.org>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
bb10
Timur Pocheptsov 2016-07-29 15:18:34 +02:00
parent a5c851598c
commit 7876add8b1
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/network/ssl/qssldiffiehellmanparameters_dummy.cpp
View File

@ -48,12 +48,10 @@ QT_BEGIN_NAMESPACE
void QSslDiffieHellmanParametersPrivate::decodeDer(const QByteArray &)
{
Q_UNIMPLEMENTED();
}
void QSslDiffieHellmanParametersPrivate::decodePem(const QByteArray &)
{
Q_UNIMPLEMENTED();
}
QT_END_NAMESPACE