whytofly
/
qt6-bb10
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QDnsLookup: Fix -Wc++11-narrowing error on 32 bit Windows 

This fixes errors like this, with Clang, for 32 bit Windows targets:

    src/network/kernel/qdnslookup_win.cpp:99:54: error: non-constant-expression cannot be narrowed from type 'DWORD' (aka 'unsigned long') to 'qsizetype' (aka 'int') in initializer list [-Wc++11-narrowing]
       99 |     if (!self->sendDnsOverTls(reply, { query.data(), dnsBufferSize }, replyBuffer))
          |                                                      ^~~~~~~~~~~~~
    src/network/kernel/qdnslookup_win.cpp:99:54: note: insert an explicit cast to silence this issue
       99 |     if (!self->sendDnsOverTls(reply, { query.data(), dnsBufferSize }, replyBuffer))
          |                                                      ^~~~~~~~~~~~~
          |                                                      static_cast<qsizetype>( )

Change-Id: If313e0910006f7556087f272123a0cfe1239f818
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
bb10
Martin Storsjö 2024-05-10 10:41:01 +03:00
parent ed6d1fa71a
commit 7e6f44f38b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/network/kernel/qdnslookup_win.cpp
View File

@ -96,7 +96,7 @@ static DNS_STATUS sendAlternate(QDnsLookupRunnable *self, QDnsLookupReply *reply
dnsBuffer->MessageHead.AuthenticatedData = true;
QDnsLookupRunnable::ReplyBuffer replyBuffer;
if (!self->sendDnsOverTls(reply, { query.data(), dnsBufferSize }, replyBuffer))
if (!self->sendDnsOverTls(reply, { query.data(), qsizetype(dnsBufferSize) }, replyBuffer))
return DNS_STATUS(-1); // error set in reply
// interpret the RCODE in the reply