qt6-bb10

History

Marc Mutz eb10876c7d Unbreak QSet::intersect() The selection of which set to iterate over and which one to remove from based on their relative size violates the function's documentation, which clearly states that items are removed from this, and not from `other`, so the result must never contain any elements from `other`. Amends `4f2c96eaa8`. Instead of reverting to the gruesome old code with the forced detach-just-to-remove copies, distinguish four cases: - if the two sets are shallow copies of each other, then their intersection is this - otherwise, if either set is empty, clear() this. This is required for one of the tests that `29017f1395` added to succeed. - otherwise, if this is detached, perform the operation in-place, using removeIf() - otherwise, create a new set and move-assign to this to avoid detaching just to remove something again. In this case, we can continue to iterate over the smaller set, but we need to keep picking elements from LHS into the result. [ChangeLog][QtCore][QSet] Fixed a regression (introduced for Qt 5.2) in intersect() that caused equivalent elements of `this` to be overwritten by elements of `other` if `other.size()` was larger than `this->size()`. Not picking to 5.15, as users will have likely adjusted their code to the buggy behavior, and because removeIf() isn't available there. Pick-to: 6.5 Fixes: QTBUG-132536 Task-number: QTBUG-106179 Change-Id: Idfa17c3b3589c4eacec27259fc01df6aeaa6c45f Reviewed-by: Øystein Heskestad <oystein.heskestad@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 162015e9c6f469951d9212ef655cff16dcace071) Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit eb13efc4a606cdb0c6f785a6319c489ad53626f3) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>		2025-02-05 15:57:55 +00:00
..
auto	Unbreak QSet::intersect()	2025-02-05 15:57:55 +00:00
baseline	test: baseline: Call finalizeAndDisconnect	2024-11-22 20:18:50 +00:00
benchmarks	Fix wrong value for 'noon' in tst_bench_qdatetime	2025-01-20 09:11:02 +00:00
global	…
libfuzzer	Complete color space toICC write	2024-05-31 16:24:50 +02:00
manual	Make iconbrowser manual test directly openable in Creator	2025-01-22 23:04:14 +00:00
shared	De-duplicate the disabling of crash dialogs in our unit tests	2025-01-20 21:30:42 +00:00
testserver	Add REUSE.toml files	2024-11-07 08:38:49 +01:00
CMakeLists.txt	…
README	…

README

This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.

Linux X11:

   * The user must be logged in to an active desktop; you can't run the
     autotests without a valid DISPLAY that allows X11 connections.

   * The tests are run against a KDE3 or KDE4 desktop.

   * Window manager uses "click to focus", and not "focus follows mouse". Many
     tests move the mouse cursor around and expect this to not affect focus
     and activation.

   * Disable "click to activate", i.e., when a window is opened, the window
     manager should automatically activate it (give it input focus) and not
     wait for the user to click the window.